This repository has been archived by the owner on Apr 7, 2021. It is now read-only.
feat: enable ues eslint to lint ts #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaohuoni
approved these changes
Mar 12, 2019
clock157
force-pushed
the
feat/support_eslint_lint_ts
branch
from
c443c42
to
4d86a59
Compare
|
eslint 也默认要配置打开的话是不是就是 breakchange 了？出于什么考虑。 |
|
好像是和我讨论的，我觉得要单独使用stylelint,要写这一串，有点奇怪 |
|
嗯，统一都默认需要配置打开是要清楚一点。 有一个方案可以考虑看看：如果没有任何类型的 lint 打开的话默认打开 eslint？ |
|
之前你觉得怪异，@xiaohuoni 也觉得怪异，我想了想也觉得怪异。so... |
|
没有任何类型打开默认打开 eslint 这个会不会也让人出现理解问题呢？ |
|
嗯，那就先这样，显示指定更清楚一点。 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
相关issue:
ant-design/ant-design-pro#3722
close #4